Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel 7 compatibility change - mangle names: #761

Merged
merged 2 commits into from
Dec 19, 2017
Merged

babel 7 compatibility change - mangle names: #761

merged 2 commits into from
Dec 19, 2017

Conversation

loborobo
Copy link
Contributor

handle getFunctionParen not returning a Program

Due to this change, mangle-names does not work with Babel 7 without this update.

@loborobo loborobo requested a review from boopathi as a code owner December 19, 2017 04:27
@boopathi
Copy link
Member

Thanks for the PR.

Looks like the lint failed. You can fix it by running yarn fix

boopathi
boopathi approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@boopathi boopathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this once the CI passes

vigneshshanmugam
vigneshshanmugam approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@vigneshshanmugam vigneshshanmugam merged commit e6a189c into babel:master Dec 19, 2017
@boopathi boopathi added the Tag: Bug Fix Pull Request fixes a bug label Dec 19, 2017
@loborobo
Copy link
Contributor Author

np. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@boopathi boopathi boopathi approved these changes

Assignees
No one assigned
Labels
Tag: Bug Fix Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loborobo @boopathi @vigneshshanmugam